Skip to content

ctr: fix label args used in NewContainer#6954

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
Iceber:fix_ctr_new_container
May 25, 2022
Merged

ctr: fix label args used in NewContainer#6954
dmcgowan merged 1 commit intocontainerd:mainfrom
Iceber:fix_ctr_new_container

Conversation

@Iceber
Copy link
Copy Markdown
Member

@Iceber Iceber commented May 18, 2022 •
edited
Loading

The ctr run and ctr container create commands use --label to specify the labels, not --labels.

# ctr containers create --help | grep label
   --label value                     specify additional labels (e.g. foo=bar)

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 18, 2022

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mikebrow
mikebrow approved these changes May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Iceber
Copy link
Copy Markdown
Member Author

Iceber commented May 23, 2022

related to #6012
@estesp PTAL, Thanks!

estesp
estesp approved these changes May 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; good catch. We should backport this fix as well

@dmcgowan dmcgowan merged commit 8ba075c into containerd:main May 25, 2022
@Iceber Iceber mentioned this pull request Jun 13, 2022
Merged
@Iceber
Copy link
Copy Markdown
Member Author

Iceber commented Jun 13, 2022

@estesp It looks like it needs cherry pick into release/1.5 #6024

@fuweid fuweid added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x labels Jun 13, 2022
@fuweid
Copy link
Copy Markdown
Member

fuweid commented Jun 13, 2022

It looks like it needs cherry pick into release/1.5 #6024

Yes, please. @Iceber

@Iceber Iceber mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Iceber @k8s-ci-robot @fuweid @dmcgowan @estesp @mikebrow @samuelkarp