Skip to content

fix some confusing typos#6950

Merged
estesp merged 1 commit intocontainerd:mainfrom
AllenZMC:fix
May 18, 2022
Merged

fix some confusing typos#6950
estesp merged 1 commit intocontainerd:mainfrom
AllenZMC:fix

Conversation

@AllenZMC
Copy link
Copy Markdown

@AllenZMC AllenZMC commented May 17, 2022

fix some confusing typos

fix some confusing typos
eaec653 
Signed-off-by: AllenZMC <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 17, 2022

Hi @AllenZMC. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mikebrow
mikebrow approved these changes May 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpuguy83
cpuguy83 approved these changes May 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For once, these aren't my typos!

LGTM!

@AllenZMC
Copy link
Copy Markdown
Author

AllenZMC commented May 17, 2022

/retest

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 17, 2022

@AllenZMC: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AllenZMC AllenZMC requested a review from mikebrow May 18, 2022 07:37
estesp
estesp approved these changes May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 405fba7 into containerd:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow Awaiting requested review from mikebrow

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AllenZMC @k8s-ci-robot @cpuguy83 @estesp @mikebrow