Skip to content

Separate windows-2019 and windows-2022 test results#6946

Merged
kzys merged 1 commit intocontainerd:mainfrom
TBBle:separate-windows-test-results
May 16, 2022
Merged

Separate windows-2019 and windows-2022 test results#6946
kzys merged 1 commit intocontainerd:mainfrom
TBBle:separate-windows-test-results

Conversation

@TBBle
Copy link
Copy Markdown
Contributor

@TBBle TBBle commented May 15, 2022

This fixes the problem that only one upload is kept per artifact name.

@TBBle
Separate windows-2019 and windows-2022 test results
6515060 
This fixes the problem that only one upload is kept per artifact name.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 15, 2022

Hi @TBBle. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TBBle
Copy link
Copy Markdown
Contributor Author

TBBle commented May 15, 2022

It worked. The Vagrant failure seems unrelated.

Before:
image

After:
image

estesp
estesp approved these changes May 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kzys
kzys approved these changes May 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

cpuguy83
cpuguy83 approved these changes May 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 42c6be8 into containerd:main May 16, 2022
@TBBle TBBle deleted the separate-windows-test-results branch May 17, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TBBle @k8s-ci-robot @kzys @cpuguy83 @estesp