[release/1.5] cherry-pick: Allow git commands in Vagrantfile#6943
Merged
dmcgowan merged 1 commit intocontainerd:release/1.5from May 13, 2022
Merged
[release/1.5] cherry-pick: Allow git commands in Vagrantfile#6943dmcgowan merged 1 commit intocontainerd:release/1.5from
dmcgowan merged 1 commit intocontainerd:release/1.5from
Conversation
Due to a git CVE, we need to mark /vagrant as a "safe" directory otherwise building containerd inside Vagrant fails with git command failures. Signed-off-by: Phil Estes <[email protected]> (cherry picked from commit 06bdfeb)
dmcgowan
approved these changes
May 13, 2022
Member
Author
|
/test pull-containerd-build |
|
@estesp: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
Author
|
Looks like some auth issue with the prow-managed jobs (well, the build one at least): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a git CVE, we need to mark /vagrant as a "safe" directory
otherwise building containerd inside Vagrant fails with git command
failures.
Cherry-pick of #6941
Signed-off-by: Phil Estes [email protected]