[release/1.6] Allow git commands in Vagrantfile#6941
Merged
mikebrow merged 1 commit intocontainerd:release/1.6from May 12, 2022
Merged
[release/1.6] Allow git commands in Vagrantfile#6941mikebrow merged 1 commit intocontainerd:release/1.6from
mikebrow merged 1 commit intocontainerd:release/1.6from
Conversation
Due to a git CVE, we need to mark /vagrant as a "safe" directory otherwise building containerd inside Vagrant fails with git command failures. Signed-off-by: Phil Estes <[email protected]>
This was referenced May 12, 2022
AkihiroSuda
approved these changes
May 12, 2022
samuelkarp
approved these changes
May 12, 2022
kzys
approved these changes
May 12, 2022
Member
|
nod build fails and .. the version of containerd in that vagrant doesn't report version correctly to the cri api.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a git CVE, we need to mark /vagrant as a "safe" directory
otherwise building containerd inside Vagrant fails with git command
failures.
Backport of #6915 for
release/1.6Signed-off-by: Phil Estes [email protected]