Skip to content

Bump OpenTelemetry dependencies#6932

Merged
estesp merged 1 commit intocontainerd:mainfrom
lucacome:bump-otel-deps
May 12, 2022
Merged

Bump OpenTelemetry dependencies#6932
estesp merged 1 commit intocontainerd:mainfrom
lucacome:bump-otel-deps

Conversation

@lucacome
Copy link
Copy Markdown
Contributor

@lucacome lucacome commented May 12, 2022

Updates OpenTelemetry dependencies. This ends up updating testify and go-cmp.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 12, 2022

Hi @lucacome. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucacome
Bump OpenTelemetry dependencies
c1140ae 
Signed-off-by: Luca Comellini <[email protected]>
@lucacome
Copy link
Copy Markdown
Contributor Author

lucacome commented May 12, 2022

/retest

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 12, 2022

@lucacome: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented May 12, 2022

/ok-to-test

estesp
estesp approved these changes May 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 133978f into containerd:main May 12, 2022
@lucacome lucacome deleted the bump-otel-deps branch June 6, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lucacome @k8s-ci-robot @mikebrow @kzys @estesp