[release/1.6] Bug fix for mount path handling#6929
[release/1.6] Bug fix for mount path handling#6929kevpar merged 1 commit intocontainerd:release/1.6from
Conversation
Currently when handling 'container_path' elements in container mounts we simply call
filepath.Clean on those paths. However, filepath.Clean adds an extra '.' if the path is a
simple drive letter ('E:' or 'Z:' etc.). These type of paths cause failures (with incorrect
parameter error) when creating containers via hcsshim. This commit checks for such paths
and doesn't call filepath.Clean on them.
It also adds a new check to error out if the destination path is a C drive and moves the
dst path checks out of the named pipe condition.
Signed-off-by: Amit Barve <[email protected]>
(cherry picked from commit bfde58e)
Signed-off-by: Amit Barve <[email protected]>
|
Hi @ambarve. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
estesp
changed the title
|
Backport of #6651 |
kevpar
changed the title
kevpar
left a comment
kevpar
left a comment
There was a problem hiding this comment.
LGTM. CI failure looks like a flake, as it's on Linux and this change only touches _windows files.
6 participants
Currently when handling 'container_path' elements in container mounts we simply call
filepath.Clean on those paths. However, filepath.Clean adds an extra '.' if the path is a
simple drive letter ('E:' or 'Z:' etc.). These type of paths cause failures (with incorrect
parameter error) when creating containers via hcsshim. This commit checks for such paths
and doesn't call filepath.Clean on them.
It also adds a new check to error out if the destination path is a C drive and moves the
dst path checks out of the named pipe condition.
Signed-off-by: Amit Barve [email protected]
(cherry picked from commit bfde58e)
Signed-off-by: Amit Barve [email protected]