Add Wait to binaryProcessor#6916
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom May 10, 2022
Merged
Conversation
Add exported `Wait(ctx context.Context) error` interface that waits on the underlying command (or context cancellation) and returns the error. This fixes a race condition between `.wait()` and `.Err error`: containerd#6914 Signed-off-by: Hamza El-Saawy <[email protected]>
|
Hi @helsaawy. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mxpv
approved these changes
May 9, 2022
dmcgowan
approved these changes
May 10, 2022
helsaawy
added a commit
to helsaawy/containerd
that referenced
this pull request
May 10, 2022
Backporting PR containerd#6916 to release 1.6 Add exported `Wait(ctx context.Context) error` interface that waits on the underlying command (or context cancellation) and returns the error. This fixes a race condition between `.wait()` and `.Err error`: containerd#6914 (cherry picked from commit ad8b87b) Signed-off-by: Hamza El-Saawy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add exported
Wait(ctx context.Context) errorinterface that waits onthe underlying command (or context cancellation) and returns the error.
This fixes a race condition between
.wait()and.Err error: #6914Signed-off-by: Hamza El-Saawy [email protected]