Pass explicit JUnit outfile to critest.exe in Windows workflow.#6912
Pass explicit JUnit outfile to critest.exe in Windows workflow.#6912dmcgowan merged 1 commit intocontainerd:mainfrom
Conversation
Following kubernetes-sigs/cri-tools#910 the Ginkgo reporters are left configured with default settings and thus do not generate a JUnit report file unless we explicitly pass a path for the outfile in the Windows workflow when calling critest.exe. Signed-off-by: Nashwan Azhari <[email protected]>
|
Hi @aznashwan. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR should fix the missing CRI test results on testgrid, which shows the tests which went unreported over the weekend because the junit_.xml file which was usually generated/uploaded by @dmcgowan @dcantah @kzys could one of you please take a look at this so we don't potentially lose more test results because of it until we can get a proper fix in kubernetes-sigs/cri-tools itself? |
5 participants
Following kubernetes-sigs/cri-tools#910 the Ginkgo reporters are left
configured with default settings and thus do not generate a JUnit report
file unless we explicitly pass a path for the outfile in the Windows
workflow when calling critest.exe.
Signed-off-by: Nashwan Azhari [email protected]