Share container images between TestRestartMonitor and TestRestartMonitorWithOnFailurePolicy#6889
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom May 4, 2022
Merged
Conversation
AkihiroSuda
reviewed
May 4, 2022
| t.Fatal(err) | ||
| } | ||
|
|
||
| t.Run("Success", func(t *testing.T) { |
Member
There was a problem hiding this comment.
Suggested change
| t.Run("Success", func(t *testing.T) { | |
| t.Run("Always", func(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
Addressed in the last revision.
AkihiroSuda
reviewed
May 4, 2022
…ailurePolicy These tests are launching containerd and pulling busybox there, while other tests are using busybox from TestMain(). This commit shares busybox at least between TestRestartMonitor and TestRestartMonitorWithOnFailurePolicy to reduce the chance of throttling from ghcr.io. Signed-off-by: Kazuyoshi Kato <[email protected]>
AkihiroSuda
approved these changes
May 4, 2022
dmcgowan
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are launching containerd and pulling busybox there, while
other tests are using busybox from TestMain().
This commit shares busybox at least between TestRestartMonitor and
TestRestartMonitorWithOnFailurePolicy to reduce the chance of
throttling from ghcr.io.
Signed-off-by: Kazuyoshi Kato [email protected]