Skip to content

Bump Golang and MinGW versions in Windows setup script.#6888

Merged
kzys merged 1 commit intocontainerd:mainfrom
aznashwan:bump-windows-ci-deps
Jun 10, 2022
Merged

Bump Golang and MinGW versions in Windows setup script.#6888
kzys merged 1 commit intocontainerd:mainfrom
aznashwan:bump-windows-ci-deps

Conversation

@aznashwan
Copy link
Copy Markdown
Contributor

Signed-off-by: Nashwan Azhari [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @aznashwan. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aznashwan aznashwan changed the title Bump Golang and MinGW versions in Windows setup script. [Do not merge] Bump Golang and MinGW versions in Windows setup script. May 3, 2022
@aznashwan
Copy link
Copy Markdown
Contributor Author

Currently doing a full CI run to validate the changes, will update the PR once I've confirmed it works.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aznashwan aznashwan force-pushed the bump-windows-ci-deps branch from eeb2c10 to 6fc7509 Compare June 2, 2022 10:51
@aznashwan aznashwan changed the title [Do not merge] Bump Golang and MinGW versions in Windows setup script. Bump Golang and MinGW versions in Windows setup script. Jun 2, 2022
@aznashwan
Copy link
Copy Markdown
Contributor Author

Re-bumped to latest versions, can confirm they work for both 2019 and 2022.

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Set-MpPreference -DisableRealtimeMonitoring:$true

$PACKAGES= @{ mingw = "10.2.0"; git = ""; golang = "1.18"; make = ""; nssm = "" }
$PACKAGES= @{ mingw = "11.2.0"; git = ""; golang = "1.18.3"; make = ""; nssm = "" }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! nice one; I definitely missed this one when grep'ing for the go version to update

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys
Copy link
Copy Markdown
Member

kzys commented Jun 3, 2022

You may need to rebase your branch to fix the Git issue.

@aznashwan aznashwan force-pushed the bump-windows-ci-deps branch from 6fc7509 to d25b4e6 Compare June 3, 2022 18:08
@kzys kzys merged commit b5ffeac into containerd:main Jun 10, 2022
aznashwan added a commit to aznashwan/containerd that referenced this pull request Jun 15, 2022
After the switch to MinGW 11.2.0 in containerd#6888, the containerd client
integration tests were crashing with an apparent  memory allocation
error as described in golang/go#46099.

This patch reverts MinGW to 10.3.0 to bypass the issue.

Signed-off-by: Nashwan Azhari <[email protected]>
kiashok pushed a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
After the switch to MinGW 11.2.0 in containerd#6888, the containerd client
integration tests were crashing with an apparent  memory allocation
error as described in golang/go#46099.

This patch reverts MinGW to 10.3.0 to bypass the issue.

Signed-off-by: Nashwan Azhari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants