Skip to content

docs: Adding windows installation steps to getting-started.md#6875

Merged
estesp merged 1 commit intocontainerd:mainfrom
marosset:windows-installation-docs
Apr 29, 2022
Merged

docs: Adding windows installation steps to getting-started.md#6875
estesp merged 1 commit intocontainerd:mainfrom
marosset:windows-installation-docs

Conversation

@marosset
Copy link
Copy Markdown
Contributor

Signed-off-by: Mark Rossetti [email protected]

These instructions used to be hosted at https://v1-22.docs.kubernetes.io/docs/setup/production-environment/container-runtimes/#containerd but have been removed.

It makes more sense to host them here.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @marosset. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread docs/getting-started.md Outdated
@marosset marosset force-pushed the windows-installation-docs branch from 0bf25eb to 9b04d2f Compare April 28, 2022 20:46
Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Mark!

Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 8ec0909 into containerd:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants