Remove github.com/gogo/protobuf and github.com/golang/protobuf from containerd's direct dependencies#6867
Merged
estesp merged 4 commits intocontainerd:mainfrom Apr 28, 2022
Merged
Conversation
While gogo isn't actually used, it is still referenced from .proto files and its corresponding Go package is imported from the auto-generated files. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
Build succeeded.
|
added 2 commits
April 27, 2022 21:31
Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
dmcgowan
approved these changes
Apr 27, 2022
2 tasks
Member
|
@dmcgowan Thoughts on backporting this change to 1.6 release? This came up while I was trying to fix proto failures in https://github.com/containerd/containerd/actions/runs/10555067168/job/29237977904?pr=10595. From go 1.22, the go get command cannot be used to fetch the modules. This change is already present in release/1.7 as part of this PR. So wanted to know thoughts on removing the gogo direct dependency from release/1.6 also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes github.com/gogo/protobuf and github.com/golang/protobuf from containerd's direct dependencies. We are not using the former anymore and the latter is superseded by google.golang.org/protobuf.