Skip to content

Cleanup leaked shim process#6866

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
ambarve:cleanup_leaked_shim
May 2, 2022
Merged

Cleanup leaked shim process#6866
dmcgowan merged 1 commit intocontainerd:mainfrom
ambarve:cleanup_leaked_shim

Conversation

@ambarve
Copy link
Copy Markdown
Contributor

@ambarve ambarve commented Apr 27, 2022

If containerd crashes while creating a container the shim process stays alive and is never
cleaned up. Details are discussed in issue #6860. This fixes the code
to cleanup such shim processes on containerd restart.

Signed-off-by: Amit Barve [email protected]

@ambarve
Cleanup leaked shim process
46773c3 
If containerd crashes while creating a container the shim process stays alive and is never
cleaned up. Details are discussed in issue containerd#6860. This fixes the code
to cleanup such shim processes on containerd restart.

Signed-off-by: Amit Barve <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 27, 2022

Hi @ambarve. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 27, 2022

Hi @ambarve. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmcgowan dmcgowan requested a review from mxpv April 27, 2022 18:53
@ambarve
Copy link
Copy Markdown
Contributor Author

ambarve commented Apr 27, 2022

@kevpar PTAL.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 27, 2022

Build succeeded.

@kevpar kevpar self-assigned this Apr 28, 2022
@kzys
Copy link
Copy Markdown
Member

kzys commented May 2, 2022

Looks good to me, but I'd like to wait either @kevpar or @mxpv before merging.

@dmcgowan dmcgowan merged commit 6fda809 into containerd:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@mxpv mxpv mxpv approved these changes

Assignees

@kevpar kevpar

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ambarve @k8s-ci-robot @kzys @dmcgowan @mxpv @kevpar