Skip to content

Don't use "uname -a" as Cirrus CI's cache key#6863

Merged
estesp merged 1 commit intocontainerd:mainfrom
kzys:cirrus-cache
Apr 27, 2022
Merged

Don't use "uname -a" as Cirrus CI's cache key#6863
estesp merged 1 commit intocontainerd:mainfrom
kzys:cirrus-cache

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Apr 27, 2022

"uname -a" includes its hostname, which could be
cirrus-task-6102504847966208, cirrus-task-6665454801387520, ...
This is unnecessary invalidating the cache.

Signed-off-by: Kazuyoshi Kato [email protected]

"uname -a" includes its hostname, which could be
cirrus-task-6102504847966208, cirrus-task-6665454801387520, ...
This is unnecessary invalidating the cache.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys
Copy link
Copy Markdown
Member Author

kzys commented Apr 27, 2022

By the way, uname -a is coming from runc. I'm gonna submit a PR :)

No. They are right. We were (well, I was) wrong.

https://github.com/opencontainers/runc/blob/48464417f4bd8bec302280094beb9849d7ad66b3/.cirrus.yml#L43-L45

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 27, 2022

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 6348a7b into containerd:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants