Skip to content

Move Vagrant-based tests from GitHub Actions to Cirrus CI #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Apr 26, 2022
Merged

Move Vagrant-based tests from GitHub Actions to Cirrus CI #6854

dmcgowan merged 1 commit into from
Apr 26, 2022

Conversation

@kzys
Copy link
Member

@kzys kzys commented Apr 25, 2022 •
edited
Loading

Cirrus CI supports nested virtualization and free to use from open
source projects. runc has been using the service since
opencontainers/runc#3088.

Signed-off-by: Kazuyoshi Kato [email protected]

@k8s-ci-robot
Copy link

k8s-ci-robot commented Apr 25, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kzys kzys force-pushed the cirrus-ci branch 5 times, most recently from ab3a2d8 to 59e308d Compare April 25, 2022 17:26
@kzys kzys changed the title Move "CGroupsV2 - rootless CRI test" from GitHub Actions to Cirrius CI Move "CGroupsV2 - rootless CRI test" from GitHub Actions to Cirrus CI Apr 25, 2022
@kzys kzys requested review from AkihiroSuda and cpuguy83 April 25, 2022 17:51
@kzys
Copy link
Member Author

kzys commented Apr 25, 2022

@AkihiroSuda - runc has been using Cirrus CI. Would you recommend containerd to move from GitHub Actions to Cirrus CI as well regarding Vagrant-based tests?

@cpuguy83 - Some of the reporting you've added wouldn't work on Cirrus CI. Would it be a blocker?

@kzys kzys changed the title Move "CGroupsV2 - rootless CRI test" from GitHub Actions to Cirrus CI Move Vagrant-based tests from GitHub Actions to Cirrus CI Apr 25, 2022
@samuelkarp
Copy link
Member

samuelkarp commented Apr 25, 2022

Cirrus CI also supports FreeBSD, which would make it possible to test containerd with the runj shim.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 25, 2022

Build succeeded.

@cpuguy83
Copy link
Member

cpuguy83 commented Apr 25, 2022

Some of the reporting you've added wouldn't work on Cirrus CI. Would it be a blocker?

Definitely 😞 but it won't break anything.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 25, 2022

Build succeeded.

@kzys kzys force-pushed the cirrus-ci branch 3 times, most recently from 2413c75 to 77413f3 Compare April 25, 2022 20:24
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 25, 2022

Build succeeded.

@kzys kzys force-pushed the cirrus-ci branch 2 times, most recently from a1f7941 to 4ce162a Compare April 25, 2022 20:42
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 25, 2022

Build succeeded.

@kzys kzys force-pushed the cirrus-ci branch 2 times, most recently from 87f6c72 to f7a7b80 Compare April 25, 2022 20:56
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 25, 2022

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 25, 2022

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2022

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2022

Build succeeded.

@kzys kzys force-pushed the cirrus-ci branch 4 times, most recently from a58ddb3 to d985b77 Compare April 26, 2022 02:27
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2022

Build succeeded.

@kzys kzys force-pushed the cirrus-ci branch 6 times, most recently from 6832c1e to 6dad8a5 Compare April 26, 2022 03:29
@kzys kzys marked this pull request as ready for review April 26, 2022 03:41
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2022

Build succeeded.

AkihiroSuda
AkihiroSuda reviewed Apr 26, 2022
View reviewed changes
.cirrus.yml Outdated
#
# Undocumented constraints;
# - The maximum memory limit is 4G times the number of CPUs.
# - The number of CPUs should be mutiple of 2.
Copy link
Member

@AkihiroSuda AkihiroSuda Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: mutiple

Copy link
Member Author

@kzys kzys Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.

AkihiroSuda
AkihiroSuda reviewed Apr 26, 2022
View reviewed changes
.cirrus.yml
HOME: /root
matrix:
BOX: fedora/35-cloud-base
BOX: rockylinux/8
Copy link
Member

@AkihiroSuda AkihiroSuda Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We could just use GCP rockylinux image without Vagrant, but that may rather complicate the script, so using Vagrant seems fine)

Copy link
Member Author

@kzys kzys Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. We technically could maintain images with our own dependencies to speed up the build, but I'm unsure it is worth to do.

AkihiroSuda
AkihiroSuda reviewed Apr 26, 2022
View reviewed changes
Vagrantfile Outdated
config.vm.provider :libvirt do |v|
v.memory = memory
v.cpus = cpus
v.machine_virtual_size = 60
Copy link
Member

@AkihiroSuda AkihiroSuda Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply the same disk size configuration to :virtualbox provider too?
https://www.vagrantup.com/docs/disks/usage

Copy link
Member Author

@kzys kzys Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It is experimental though.

@kzys
Copy link
Member Author

kzys commented Apr 26, 2022 •
edited
Loading

Sadly I had to re-run "Cirrus CI / Vagrant BOX:rockylinux/8" once. I'm unsure that the instability was coming from our tests or Cirrus CI.

Good news is that other two tests were finishing earlier than "CI / Windows Integration (windows-2022)" and "CI / Linux Integration (io.containerd.runc.v1, runc)". If this trend continues, Cirrus CI wouldn't be our bottleneck, in terms of its speed.

Move Vagrant-based tests from GitHub Actions to Cirrus CI
5f43118 
Cirrus CI supports nested virtualization and free to use from open
source projects. runc has been using the service since
opencontainers/runc#3088.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2022

Build succeeded.

@dmcgowan dmcgowan merged commit 8e74f2a into containerd:main Apr 26, 2022
@thaJeztah thaJeztah mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@cpuguy83 cpuguy83 Awaiting requested review from cpuguy83

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kzys @k8s-ci-robot @samuelkarp @cpuguy83 @dmcgowan @AkihiroSuda