Skip to content

fix incorrect syntax in comments#6845

Merged
estesp merged 1 commit intocontainerd:mainfrom
my-git9:test1
Apr 25, 2022
Merged

fix incorrect syntax in comments#6845
estesp merged 1 commit intocontainerd:mainfrom
my-git9:test1

Conversation

@my-git9
Copy link
Copy Markdown
Contributor

@my-git9 my-git9 commented Apr 24, 2022 •
edited
Loading

fix incorrect syntax in comments
add ".idea/" to .gitignore

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 24, 2022

Hi @my-git9. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 24, 2022

Build succeeded.

AkihiroSuda
AkihiroSuda reviewed Apr 25, 2022
View reviewed changes
Comment thread .gitignore Outdated
releases/*.tar.gz.sha256sum
_output/
.vagrant/
.idea/
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.idea/

This should be in your personal gitignore.

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Apr 25, 2022

Please squash commits

@my-git9 my-git9 force-pushed the test1 branch 3 times, most recently from 0c84295 to bb8e344 Compare April 25, 2022 07:27
@my-git9
fix incorrect syntax in comments
da3e2f9 
Signed-off-by: xin.li <[email protected]>

Signed-off-by: xin.li <[email protected]>

Signed-off-by: xin.li <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 25, 2022

Build succeeded.

estesp
estesp approved these changes Apr 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 4ef928a into containerd:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@qiutongs qiutongs qiutongs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@my-git9 @k8s-ci-robot @AkihiroSuda @samuelkarp @estesp @qiutongs