Migrate off from github.com/gogo/protobuf #6841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
kzys
force-pushed
the
proto-upgrade-6
branch
9 times, most recently
from
daedf7b to
84d2248
Compare
|
Build succeeded.
|
kzys
force-pushed
the
proto-upgrade-6
branch
3 times, most recently
from
314eb2c to
e656e08
Compare
|
Build succeeded.
|
kzys
force-pushed
the
proto-upgrade-6
branch
2 times, most recently
from
d188149 to
ecf23ba
Compare
|
Build succeeded.
|
kzys
force-pushed
the
proto-upgrade-6
branch
3 times, most recently
from
060c567 to
a0403dc
Compare
|
Build succeeded.
|
kzys
force-pushed
the
proto-upgrade-6
branch
2 times, most recently
from
e918c36 to
e0a69c0
Compare
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
added 5 commits
April 22, 2022 15:31
protoc-gen-go-ttrpc's generated Go code doesn't work with ttrpc v1.1.0. Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
This commit migrates containerd/protobuf from github.com/gogo/protobuf to google.golang.org/protobuf and adjust types. Proto-generated structs cannot be passed as values. Fixes containerd#6564. Signed-off-by: Kazuyoshi Kato <[email protected]>
Previouslty "Size" was reserved by protoc-gen-gogoctrd and user-generated "Size" was automatically renamed to "Size_" to avoid conflicts. Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
added 3 commits
April 22, 2022 15:40
containerd/typeurl#35 is needed to handle types generated by protoc-gen-go. Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
Member
Author
|
Since containerd/typeurl#35 has been merged (with only one review, sorry), this is ready for review and merge! |
dmcgowan
approved these changes
Apr 22, 2022
samuelkarp
approved these changes
Apr 22, 2022
This was referenced Apr 25, 2022
2 tasks
This was referenced Feb 25, 2023
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates containerd off from github.com/gogo/protobuf.
This PR touches 160+ files, but many of them are auto-generated and they are in "make protos" and "go mod tidy and go mod vendor" commits. It would be easier to review commit-by-commit (and skimming them) rather than reviewing the whole PR in "Files changed" tab.