Prepare for google.golang.org/protobuf#6835
Merged
estesp merged 3 commits intocontainerd:mainfrom Apr 21, 2022
Merged
Conversation
added 2 commits
April 20, 2022 17:14
Embedding these structs will be mandatory after migratring off from gogo/protobuf (see containerd#6564). Signed-off-by: Kazuyoshi Kato <[email protected]>
With google.golang.org/protobuf, proto-generated objects only have ProtoReflect(). They don't have Marshal() anymore (see containerd#6564). Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Skipping CI for Draft Pull Request. |
Seems it is no longer optional after migratring off from gogo/protobuf (see containerd#6564). Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
dmcgowan
approved these changes
Apr 21, 2022
samuelkarp
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are coming from my private google.golang.org/protobuf branch and could be applied before the migration.