diff: hide types.Any from clients#6832
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Apr 21, 2022
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
kzys
force-pushed
the
imgcrypt-typeurl
branch
4 times, most recently
from
c9c8fad to
f8ef7c8
Compare
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
kzys
force-pushed
the
imgcrypt-typeurl
branch
2 times, most recently
from
42b2df4 to
0368bb6
Compare
|
Build succeeded.
|
kzys
force-pushed
the
imgcrypt-typeurl
branch
2 times, most recently
from
67a1b7b to
f817e15
Compare
|
Build succeeded.
|
|
Build succeeded.
|
kzys
changed the title
This commit hides types.Any from the diff package's interface. Clients (incl. imgcrypt) shouldn't aware about gogo/protobuf. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
dmcgowan
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Please review and merge containerd/imgcrypt#75 first)
This commit hides types.Any from the diff package's interface. Clients
(incl. imgcrypt) shouldn't aware about gogo/protobuf.