Fix protoc-gen-go-fieldpath#6828
Merged
dmcgowan merged 2 commits intocontainerd:mainfrom Apr 20, 2022
Merged
Conversation
added 2 commits
April 19, 2022 22:11
The generator has to handle nested fields such as https://github.com/containerd/containerd/blob/902212651b12e4d81b7bc779632b2e4da0a8e673/api/events/container.proto#L31-L35. Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
mxpv
approved these changes
Apr 20, 2022
dmcgowan
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator has to handle nested fields such as
containerd/api/events/container.proto
Lines 31 to 35 in 9022126
Signed-off-by: Kazuyoshi Kato [email protected]