Remove gogoproto.stdtime#6821
Merged
estesp merged 1 commit intocontainerd:mainfrom Apr 19, 2022
Merged
Conversation
kzys
force-pushed
the
remove-std-time
branch
2 times, most recently
from
f74304e to
96226d9
Compare
cpuguy83
reviewed
Apr 18, 2022
| } | ||
|
|
||
| // FromTimestamp creates time.Time from protobuf's Timestamp | ||
| func FromTimestamp(from *types.Timestamp) time.Time { |
Member
There was a problem hiding this comment.
Note that protobuf/types already implements this: https://github.com/gogo/protobuf/blob/b03c65ea87cdc3521ede29f62fe3ce239267c1bc/types/timestamp.go#L88-L98
There's some validation there (which I didn't dig into yet), but the other case is a nil timestamp.
Member
Author
There was a problem hiding this comment.
Oh, how didn't I notice that. Let me fix.
| // ToTimestamp creates protobuf's Timestamp from time.Time | ||
| func ToTimestamp(from time.Time) *types.Timestamp { | ||
| return &types.Timestamp{ | ||
| Seconds: int64(from.Second()), |
Member
There was a problem hiding this comment.
Note that protobuf/types does this as Seconds: from.Unix()
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
dmcgowan
approved these changes
Apr 19, 2022
Member
|
Looks like this needs a rebase, @kzys |
This commit removes gogoproto.stdtime, since it is not supported by Google's official toolchain (see containerd#6564). Signed-off-by: Kazuyoshi Kato <[email protected]>
Member
Author
|
@thaJeztah Thanks. Merged sandbox changes and removed stdtime from the new protos as well. |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes gogoproto.stdtime, since it is not supported by
Google's official toolchain
(see #6564).
Signed-off-by: Kazuyoshi Kato [email protected]