Skip to content

Move lease manager plugin to separate package#6811

Merged
fuweid merged 1 commit intocontainerd:mainfrom
dmcgowan:lease-plugin
Apr 18, 2022
Merged

Move lease manager plugin to separate package#6811
fuweid merged 1 commit intocontainerd:mainfrom
dmcgowan:lease-plugin

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Create lease plugin type to separate lease manager from services plugin. This allows other service plugins to depend on the lease manager.

@dmcgowan dmcgowan added this to the 1.7 milestone Apr 15, 2022
Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread leases/plugin/local.go
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 15, 2022

Build succeeded.

Comment thread plugin/plugin.go Outdated
Create lease plugin type to separate lease manager from services plugin.
This allows other service plugins to depend on the lease manager.

Signed-off-by: Derek McGowan <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 15, 2022

Build succeeded.

@fuweid fuweid merged commit 7cbde74 into containerd:main Apr 18, 2022
@dmcgowan dmcgowan deleted the lease-plugin branch April 18, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants