Skip to content

fix pool_device_test#6807

Merged
estesp merged 1 commit intocontainerd:mainfrom
shnmorimoto:fix_pool_device_test
Apr 15, 2022
Merged

fix pool_device_test#6807
estesp merged 1 commit intocontainerd:mainfrom
shnmorimoto:fix_pool_device_test

Conversation

@shnmorimoto
Copy link
Copy Markdown
Contributor

@shnmorimoto shnmorimoto commented Apr 14, 2022

fixed #6627

Issue

While executing mke2fs, 'Not enough space to build proposed filesystem while setting up superblock' is happend.

Fix

extend the disk size.

On the original issue #6627 , the architecture (ppc64le) is the cause, but it is reproduced on Ubuntu 20.04 on x86-64 and not reproduced on Ubuntu18.04 on ppc64le.
So, I think it is caused by the change in Ubuntu version.

make root-test result is below.

before change

ubuntu20.04 on x86-64 (EC2)

+ root-test
...
--- FAIL: TestPoolDevice (1.65s)
    --- FAIL: TestPoolDevice/MakeFileSystem (0.01s)
        pool_device_test.go:245:
                Error Trace:    pool_device_test.go:245
                                                        pool_device_test.go:103
                Error:          Expected nil, but got: &exec.ExitError{ProcessState:(*os.ProcessState)(0xc0002677d0), Stderr:[]uint8(nil)}
                Test:           TestPoolDevice/MakeFileSystem
                Messages:       failed to make filesystem on 'thin-1': mke2fs 1.45.5 (07-Jan-2020)
                                /dev/mapper/thin-1: Not enough space to build proposed filesystem while setting up superblock
        pool_device_test.go:249:
                Error Trace:    pool_device_test.go:249
                                                        pool_device_test.go:103
                Error:          Should be true
                Test:           TestPoolDevice/MakeFileSystem
    pool_device_test.go:130:
                Error Trace:    pool_device_test.go:130
                Error:          Received unexpected error:
                                failed to mount /run/user/0/containerd-mount2737791447: invalid argument
                Test:           TestPoolDevice
    pool_device_test.go:142:
                Error Trace:    pool_device_test.go:142
                Error:          Received unexpected error:
                                failed to mount /run/user/0/containerd-mount1848998475: invalid argument
                Test:           TestPoolDevice
...

ubuntu20.04 on ppc64el (QEMU)

+ root-test
....

--- FAIL: TestPoolDevice (42.77s)
    --- FAIL: TestPoolDevice/MakeFileSystem (1.15s)
        pool_device_test.go:245:
            	Error Trace:	pool_device_test.go:245
            	            				pool_device_test.go:103
            	Error:      	Expected nil, but got: &exec.ExitError{ProcessState:(*os.ProcessState)(0xc000214060), Stderr:[]uint8(nil)}
            	Test:       	TestPoolDevice/MakeFileSystem
            	Messages:   	failed to make filesystem on 'thin-1': mke2fs 1.45.5 (07-Jan-2020)
            	            	/dev/mapper/thin-1: Not enough space to build proposed filesystem while setting up superblock
        pool_device_test.go:249:
            	Error Trace:	pool_device_test.go:249
            	            				pool_device_test.go:103
            	Error:      	Should be true
            	Test:       	TestPoolDevice/MakeFileSystem
    pool_device_test.go:130:
        	Error Trace:	pool_device_test.go:130
        	Error:      	Received unexpected error:
        	            	failed to mount /run/user/1000/containerd-mount3435104661: invalid argument
        	Test:       	TestPoolDevice
    pool_device_test.go:142:
        	Error Trace:	pool_device_test.go:142
        	Error:      	Received unexpected error:
        	            	failed to mount /run/user/1000/containerd-mount3924761438: invalid argument
        	Test:       	TestPoolDevice

...

after change

ubuntu20.04 on x86-64 (EC2)

+ root-test
ok      github.com/containerd/containerd/archive        1.353s
ok      github.com/containerd/containerd/metadata       25.322s
ok      github.com/containerd/containerd/mount  0.633s
ok      github.com/containerd/containerd/oci    0.074s
ok      github.com/containerd/containerd/runtime/v1/linux       0.042s
ok      github.com/containerd/containerd/runtime/v2     0.042s
ok      github.com/containerd/containerd/snapshots/btrfs        0.029s
ok      github.com/containerd/containerd/snapshots/devmapper    67.495s
ok      github.com/containerd/containerd/snapshots/devmapper/dmsetup    0.606s
ok      github.com/containerd/containerd/snapshots/native       14.947s
ok      github.com/containerd/containerd/snapshots/overlay      29.535s
ok      github.com/containerd/containerd/snapshots/overlay/overlayutils 0.024s [no tests to run]

ubuntu20.04 on ppc64el (QEMU)

+ root-test
ok  	github.com/containerd/containerd/archive	89.362s
ok  	github.com/containerd/containerd/metadata	450.899s
ok  	github.com/containerd/containerd/mount	18.712s
ok  	github.com/containerd/containerd/oci	4.244s
ok  	github.com/containerd/containerd/runtime/v1/linux	3.634s
ok  	github.com/containerd/containerd/runtime/v2	4.581s
ok  	github.com/containerd/containerd/snapshots/btrfs	408.540s
ok  	github.com/containerd/containerd/snapshots/devmapper	890.803s
ok  	github.com/containerd/containerd/snapshots/devmapper/dmsetup	33.302s
ok  	github.com/containerd/containerd/snapshots/native	385.485s
ok  	github.com/containerd/containerd/snapshots/overlay	448.571s
ok  	github.com/containerd/containerd/snapshots/overlay/overlayutils	1.914s [no tests to run]

Signed-off-by: Shinichi Morimoto [email protected]

@shnmorimoto
fix pool_device_test.go
942af12 
While executing mke2fs, 'Not enough space to build proposed filesystem while setting up superblock' error is happend on Ubuntu20.04

Signed-off-by: Shinichi Morimoto <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 14, 2022

Hi @shnmorimoto. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build succeeded.

@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Apr 14, 2022

/ok-to-test

samuelkarp
samuelkarp approved these changes Apr 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Apr 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit fed7df1 into containerd:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ppc64 - Change disk size value in devmapper test

5 participants

@shnmorimoto @k8s-ci-robot @samuelkarp @dmcgowan @estesp