Do not append []string{""} to command to preserve Docker compatibility#6805
Merged
fuweid merged 1 commit intocontainerd:mainfrom Apr 14, 2022
Merged
Do not append []string{""} to command to preserve Docker compatibility#6805fuweid merged 1 commit intocontainerd:mainfrom
fuweid merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @zuzzas. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Andrey Klimentyev <[email protected]>
zuzzas
force-pushed
the
reset-empty-entrypoint
branch
from
2518336 to
5f3ce95
Compare
|
Build succeeded.
|
AkihiroSuda
approved these changes
Apr 14, 2022
Member
|
/ok-to-test |
fuweid
approved these changes
Apr 14, 2022
thaJeztah
added
cherry-picked/1.6.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve compatibility with
docker run: https://github.com/moby/moby/blob/99b2894e17528d0f8640d91bc3c0001e5a99cb3b/daemon/create.go#L279-L282Some build tools (notably
docker buildanddocker commit) create a string slice with an empty string as the first member. This gets stripped indocker runand works transparently if you use docker/moby as container runtime. Does not work so well in the containerd, unfortunately.