Add collectible resources to metadata gc #6804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Adds a registration function to metadata which allows plugins to register resources to be garbage collected. These resources allow defining resources types which are ephemeral and stored outside the metadata plugin without extending it. The garbage collection of these resources will not fail the metadata gc process if their removal fails. These resources may be referenced by existing metadata store resources but may not be used to reference metadata store resources for the purpose of preventing garbage collection. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
metadata-collectible-resources
branch
from
a0c02c7 to
8367f69
Compare
|
Build succeeded.
|
fuweid
reviewed
Apr 19, 2022
fuweid
reviewed
Apr 19, 2022
Member
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
Basically, the change looks good.
The development doc is wanted I think~ It is not blocked.
Ensure the registered resource type does not conflict with existing resource types or over the max. Signed-off-by: Derek McGowan <[email protected]>
|
Build succeeded.
|
mxpv
approved these changes
Apr 22, 2022
kzys
approved these changes
Apr 25, 2022
This was referenced Feb 25, 2023
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a registration function to metadata which allows plugins to register resources to be garbage collected. These resources allow defining resources types which are ephemeral and stored outside the metadata plugin without extending it. The garbage collection of these resources will not fail the metadata gc process if their removal fails. These resources may be referenced by existing metadata store resources but may not be used to reference metadata store resources for the purpose of preventing garbage collection.
This is split out from my work on the new image transfer service which will use this for tracking progress streams. This could also be used in the implementation of a mount and network manager after the sandbox API is merged.