Skip to content

Pin upload-cloud-storage action to 0.8.0 in Windows workflow.#6790

Merged
kzys merged 1 commit intocontainerd:mainfrom
aznashwan:windows-gcloud-upload-pin
Apr 8, 2022
Merged

Pin upload-cloud-storage action to 0.8.0 in Windows workflow.#6790
kzys merged 1 commit intocontainerd:mainfrom
aznashwan:windows-gcloud-upload-pin

Conversation

@aznashwan
Copy link
Copy Markdown
Contributor

@aznashwan aznashwan commented Apr 8, 2022

Pin the version of the google-github-actions/upload-cloud-storage
action library to 0.8.0 to avoid a regression which prevents
test results being uploaded in the Windows periodic workflow.

Signed-off-by: Nashwan Azhari [email protected]

@aznashwan
Pin upload-cloud-storage action to 0.8.0 in Windows workflow.
7e70ad9 
Pin the version of the `google-github-actions/upload-cloud-storage`
action library to `0.8.0` to avoid a regression which prevents
test results being uploaded in the Windows periodic workflow.

Signed-off-by: Nashwan Azhari <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 8, 2022

Hi @aznashwan. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aznashwan
Copy link
Copy Markdown
Contributor Author

aznashwan commented Apr 8, 2022

Full context: this recent issue on google-github-actions/upload-cloud-storage has lead to this failure in the Windows periodic tests earlier today.

I can confirm that pinning the version does avoid the issue entirely in this this test run.

@dmcgowan @dcantah @kzys could one of you please be kind enough to merge this so we don't potentially lose the results of the CI runs scheduled over the weekend as well?

dcantah
dcantah approved these changes Apr 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 8, 2022

Build succeeded.

@kzys kzys merged commit b5ef9b4 into containerd:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aznashwan @k8s-ci-robot @kzys @dcantah