Skip to content

Skip flaky test on Windows#6779

Merged
kzys merged 1 commit intocontainerd:mainfrom
gabriel-samfira:skip-flaky-test
Apr 5, 2022
Merged

Skip flaky test on Windows#6779
kzys merged 1 commit intocontainerd:mainfrom
gabriel-samfira:skip-flaky-test

Conversation

@gabriel-samfira
Copy link
Copy Markdown
Contributor

The tty test fails on ltsc2022. Disable that test until we manage to reproduce and fix it.

Signed-off-by: Gabriel Adrian Samfira [email protected]

The tty test fails on ltsc2022. Disable that test until we manage to
reproduce and fix it.

Signed-off-by: Gabriel Adrian Samfira <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @gabriel-samfira. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 5, 2022

Build succeeded.

@kzys kzys merged commit 626608e into containerd:main Apr 5, 2022
@dcantah
Copy link
Copy Markdown
Member

dcantah commented Apr 6, 2022

Oh this was finally reproing on the az machines? (or just to be consistent with what we did on the Actions runs?)

@gabriel-samfira
Copy link
Copy Markdown
Contributor Author

It creeps up during periodic tests. I was able to reproduce it once running the test in a loop on an azure machine. Took almost a day. Spelunking through the logs. Testing a fix will be interesting, considering the low rate of incidence during manual testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants