Disable writing freelist to make the file robust against data corruptions#6761
Disable writing freelist to make the file robust against data corruptions#6761dmcgowan merged 1 commit intocontainerd:mainfrom
Conversation
kzys
changed the title
…ions A bbolt database has a freelist to track all pages that are available for allocation. However writing the list takes some time and reading the list sometimes panics. This commit sets NoFreelistSync true to skipping the freelist entirely, following what etcd does. https://github.com/etcd-io/etcd/blob/v3.5.2/server/mvcc/backend/config_linux.go#L31 Fixes containerd#4838. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
|
Is this commit in the 1.6.x series? Or did it only make it into 1.7.0 series (currently at beta.0) |
|
@deitch Currently in 1.7.x but I can backport that to 1.6.x. |
|
That would be great. Thank you. |
logs snippet attached for your reference: Oct 28 06:24:30 raspberrypi containerd[2423528]: time="2024-10-28T06:24:30.993497139+03:00" level=info msg="Connect containerd service" Oct 28 06:24:47 raspberrypi containerd[2423693]: /usr/local/go/src/sync/once.go:65 containerd --version |
5 participants
A bbolt database has a freelist to track all pages that are available
for allocation. However writing the list takes some time and reading
the list sometimes panics.
This commit sets NoFreelistSync true for skipping the freelist entirely,
following what etcd does.
https://github.com/etcd-io/etcd/blob/v3.5.2/server/mvcc/backend/config_linux.go#L31
Fixes #4838.
Signed-off-by: Kazuyoshi Kato [email protected]