Adding multi-arch support for the configure.sh script#6751
Adding multi-arch support for the configure.sh script#6751estesp merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @nobellium1997. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
4 times, most recently
from
a5a0166 to
f95260f
Compare
|
Build succeeded.
|
| # deciding it in cloud init. This may cause issue to reboot test. | ||
| version=$(curl -f --ipv4 --retry 6 --retry-delay 3 --silent --show-error \ | ||
| https://storage.googleapis.com/${deploy_path}/latest) | ||
| if [ $(arch) == "aarch64" ]; then |
There was a problem hiding this comment.
Is it better to use uname -m? arch isn't on all linux systems
There was a problem hiding this comment.
Ah good point. Fixed.
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
from
f95260f to
94fd4b0
Compare
This script is used by various tests to install and configure containerd. However, right now it's hardcoded to only support x86 and not other architectures like arm. This change will now check the architecture of the machine the script is running on and will pull the correct artifacts accordingly from the correct artifact store (GCS vs Github). Signed-off-by: Nobel Barakat <[email protected]>
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
from
94fd4b0 to
4bdac2b
Compare
|
Build succeeded.
|
5 participants
This script is used by various tests to install and configure
containerd. However, right now it's hardcoded to only support x86
and not other architectures like arm. This change will now check the
architecture of the machine the script is running on and will pull
the correct artifacts accordingly from the correct artifact store
(GCS vs Github).
Signed-off-by: Nobel Barakat [email protected]