Add no_tracing tag#6750
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Apr 4, 2022
Merged
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
|
Build succeeded.
|
Member
|
Looks good to me. Would it impact the binary size? More about trimming down unneeded code just in case? |
Member
Author
The binary size wasn't the goal for my case. But ❯ make bin/containerd
bin/containerd
❯ du -sh bin/containerd
23M bin/containerd
❯ make bin/containerd BUILDTAGS=no_tracing
bin/containerd
❯ du -sh bin/containerd
22M bin/containerdSlightly less.
In my specific case I'm getting lots go mod conflicts when there are 2 imports which depend on different versions of opentelemetry (like |
kzys
approved these changes
Apr 1, 2022
dmcgowan
approved these changes
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracing plugin pulls in a few heavy vendor dependencies, which is not always a requirement.
For cases, when tracing is not needed, this PR adds
no_tracingbuild tag to exclude it at build time.Signed-off-by: Maksym Pavlenko [email protected]