Skip to content

added make help for cri integration#6743

Merged
estesp merged 1 commit intocontainerd:mainfrom
Jordy24:makehelp
Mar 29, 2022
Merged

added make help for cri integration#6743
estesp merged 1 commit intocontainerd:mainfrom
Jordy24:makehelp

Conversation

@Jordy24
Copy link
Copy Markdown
Contributor

@Jordy24 Jordy24 commented Mar 28, 2022

Signed-off-by: Jordan Karaze [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @Jordy24. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 28, 2022

Build succeeded.

@Jordy24 Jordy24 marked this pull request as ready for review March 28, 2022 21:59
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 28, 2022

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks Jordan!

@mikebrow
Copy link
Copy Markdown
Member

/ok-to-test

@estesp
Copy link
Copy Markdown
Member

estesp commented Mar 29, 2022

/test pull-containerd-node-e2e

@k8s-ci-robot
Copy link
Copy Markdown

@Jordy24: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerd-node-e2e cf571fa link true /test pull-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@estesp
Copy link
Copy Markdown
Member

estesp commented Mar 29, 2022

Looks like something is up with the e2e tests, but given this PR only changes comments and docs, I'm pretty sure we don't need to validate e2e node tests :)

@estesp estesp merged commit 11685cc into containerd:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants