[release/1.5] Upgrade Go to 1.17 and golangci-lint#6719
Merged
dmcgowan merged 4 commits intocontainerd:release/1.5from Mar 23, 2022
Merged
[release/1.5] Upgrade Go to 1.17 and golangci-lint#6719dmcgowan merged 4 commits intocontainerd:release/1.5from
dmcgowan merged 4 commits intocontainerd:release/1.5from
Conversation
The GitHub Action is unstable especially on Windows (see containerd#6618). This change may not address the issue itself, but using the latest version makes reporting the upstream the issue easier. Signed-off-by: Kazuyoshi Kato <[email protected]> (cherry picked from commit 622a35a) Signed-off-by: Derek McGowan <[email protected]>
thaJeztah
reviewed
Mar 23, 2022
| @@ -1,3 +1,4 @@ | |||
| //go:build !windows | |||
Member
There was a problem hiding this comment.
This branch is still on go1.16, so looks like these changes must be reverted 😞
Error: File is not `gofmt`-ed with `-s` (gofmt)
Error: File is not `gofmt`-ed with `-s` (gofmt)
Error: File is not `gofmt`-ed with `-s` (gofmt)
Not sure which file this is complaining about though 😞 let me try running it locally
Warning: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
Warning: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
dmcgowan
force-pushed
the
backport-1.5-6666
branch
from
e2ada75 to
db21cdf
Compare
Signed-off-by: Derek McGowan <[email protected]>
Member
|
@dmcgowan this looks to be the one for the error-message; |
dmcgowan
force-pushed
the
backport-1.5-6666
branch
from
db21cdf to
bc4c147
Compare
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
backport-1.5-6666
branch
from
fab5aad to
7f03aea
Compare
|
Build succeeded.
|
dmcgowan
changed the title
samuelkarp
approved these changes
Mar 23, 2022
Member
samuelkarp
left a comment
samuelkarp
left a comment
There was a problem hiding this comment.
+433 −4,951
Wow.
LGTM though.
kzys
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6666