Skip to content

fix: ctr images mount with snapshotter option can't get snapshotter#6713

Merged
fuweid merged 1 commit intocontainerd:mainfrom
cosmoer:fix-ctr-images-mount-command
Mar 24, 2022
Merged

fix: ctr images mount with snapshotter option can't get snapshotter#6713
fuweid merged 1 commit intocontainerd:mainfrom
cosmoer:fix-ctr-images-mount-command

Conversation

@cosmoer
Copy link
Copy Markdown
Contributor

@cosmoer cosmoer commented Mar 23, 2022

ctr images mount with snapshotter option can't get the specified parameter value.

example:
ctr images mount --snapshotter "aufs" docker.io/library/busybox:latest /mnt
The actual snapshotter used by the above command is the default snapshotter--"overlayfs".

Signed-off-by: Qian Zhang [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 23, 2022

Hi @cosmoer. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 23, 2022

Build succeeded.

kzys
kzys approved these changes Mar 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Other commands under images takes context.String("snapshotter"). Only this one is using GlobalString().

@fuweid fuweid merged commit 595ad06 into containerd:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cosmoer @k8s-ci-robot @kzys @fuweid @dmcgowan