Remove gogoproto.customtype #6699
Conversation
kzys
force-pushed
the
remove-customtype
branch
3 times, most recently
from
7d3e6a8 to
9fb32c9
Compare
gogoproto.customtype is used to have go-digest.Digest instead of string. While it is convinient, protoc-gen-go doesn't support the extension and that blocks containerd#6564. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
|
is this something consumers would consider a breaking change to our API? seems that any gRPC consumers have to change their code (similar to the changes in this PR) to continue to use the API with a string versus a Digest type. |
|
The change doesn't impact the wire format, but it impacts the auto-generated structs. Most request/response structs are not used by the clients who use our official Go client. The event structs may be the most external-facing one. |
This shouldn't affect client users, but there are always users of any given go package that might run into this. For 1.7 release we should track all these potential issues, then we can decide on how to proceed with the next release versioning. The route we all seem to agree on is 1.7 with new features and limited client breaks alongside extending 1.6 support, but we can always fallback to breaking more stuff and releasing as 2.0, likely also extending 1.6 support. Overall this change is better going forward as we have already done the effort of keeping the generated code out of our client interface. It is also more explicit for when a digest has been validated or not since now generated code users aren't just given an unvalidated |
4 participants
gogoproto.customtype is used to have go-digest.Digest instead of string.
While it is convinient, protoc-gen-go doesn't support the extension
and blocks #6564.
Signed-off-by: Kazuyoshi Kato [email protected]