Skip tty critest testcase on Windows Server 2022#6698
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build succeeded.
|
|
Had this on draft as I was out most of the day and wouldn't be able to fix anything if it failed 😄. Doesn't seem like this actually skipped the test even though the if condition should definitely have been entered.. Looking |
|
Oh, I didn't notice this PR until now, and just finished throwing together the same idea (but I was lazy and just skipped the test on all Windows versions, so this PR is better). I suspect the reason it didn't skip is that it's |
|
@TBBle Oh duh, changing shortly |
dcantah
force-pushed
the
skip-windows-critest-tty
branch
from
f6f54d1 to
93af84c
Compare
|
Build succeeded.
|
Skip the 'runtime should support exec with tty=true and stdin=true' test for now as it's exceedingly flaky only on Ws2022.. Doesn't seem to reproduce on a local ws2022 machine, but don't want to keep the CI red while we investigate. Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
skip-windows-critest-tty
branch
from
93af84c to
e9bb9c3
Compare
|
Looks like either --ginkgo.skip or -ginkgo-skip is accepted.. weird. But the issue just lied in how it was being parsed. Should work now, will wait for CI to complete to undraft |
|
looks like it worked: |
|
Build succeeded.
|
6 participants
Skip the 'runtime should support exec with tty=true and stdin=true' test
for now as it's exceedingly flaky only on Ws2022.. Doesn't seem to reproduce
on a local ws2022 machine, but don't want to keep the CI red while we
investigate.