Skip to content

Update prometheus client vendor#6690

Merged
crosbymichael merged 3 commits intocontainerd:mainfrom
estesp:update-prom-dep
Mar 18, 2022
Merged

Update prometheus client vendor#6690
crosbymichael merged 3 commits intocontainerd:mainfrom
estesp:update-prom-dep

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Mar 17, 2022

Update to the recent release (includes a CVE fix) of the Go prom client library

Signed-off-by: Phil Estes [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 17, 2022

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 17, 2022

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 17, 2022

Build succeeded.

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Mar 17, 2022

Passes locally on macOS with v1.44.2 golangci-lint and the same config as CI.. so ...

The linter on platforms that have a hardcoded response complains about
"if xyz == nil" checks; ignore those.

Signed-off-by: Phil Estes <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 17, 2022

Build succeeded.

Comment thread .github/workflows/ci.yml
- uses: golangci/golangci-lint-action@v3
with:
version: v1.44.2
skip-cache: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to golangci/golangci-lint-action#420?

@estesp Do you want to refine the commit message before merging?

@crosbymichael crosbymichael merged commit 0c70165 into containerd:main Mar 18, 2022
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants