Skip to content

vendor: golang.org/x/crypto v0.0.0-20220315160706-3147a52a75dd#6687

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
thaJeztah:bump_crypto
Mar 18, 2022
Merged

vendor: golang.org/x/crypto v0.0.0-20220315160706-3147a52a75dd#6687
AkihiroSuda merged 1 commit intocontainerd:mainfrom
thaJeztah:bump_crypto

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

full diff: golang/crypto@32db794...3147a52

This version contains a fix for CVE-2022-27191 (not sure if it affects us).

From the golang mailing list:

Hello gophers,

Version v0.0.0-20220315160706-3147a52a75dd of golang.org/x/crypto/ssh implements
client authentication support for signature algorithms based on SHA-2 for use with
existing RSA keys.

Previously, a client would fail to authenticate with RSA keys to servers that
reject signature algorithms based on SHA-1. This includes OpenSSH 8.8 by default
and—starting today March 15, 2022 for recently uploaded keys.

We are providing this announcement as the error (“ssh: unable to authenticate”)
might otherwise be difficult to troubleshoot.

Version v0.0.0-20220314234659-1baeb1ce4c0b (included in the version above) also
fixes a potential security issue where an attacker could cause a crash in a
golang.org/x/crypto/ssh server under these conditions:

- The server has been configured by passing a Signer to ServerConfig.AddHostKey.
- The Signer passed to AddHostKey does not also implement AlgorithmSigner.
- The Signer passed to AddHostKey does return a key of type “ssh-rsa” from its PublicKey method.

Servers that only use Signer implementations provided by the ssh package are
unaffected. This is CVE-2022-27191.

Alla prossima,

Filippo for the Go Security team

full diff: golang/crypto@32db794...3147a52

This version contains a fix for CVE-2022-27191 (not sure if it affects us).

From the golang mailing list:

    Hello gophers,

    Version v0.0.0-20220315160706-3147a52a75dd of golang.org/x/crypto/ssh implements
    client authentication support for signature algorithms based on SHA-2 for use with
    existing RSA keys.

    Previously, a client would fail to authenticate with RSA keys to servers that
    reject signature algorithms based on SHA-1. This includes OpenSSH 8.8 by default
    and—starting today March 15, 2022 for recently uploaded keys.

    We are providing this announcement as the error (“ssh: unable to authenticate”)
    might otherwise be difficult to troubleshoot.

    Version v0.0.0-20220314234659-1baeb1ce4c0b (included in the version above) also
    fixes a potential security issue where an attacker could cause a crash in a
    golang.org/x/crypto/ssh server under these conditions:

    - The server has been configured by passing a Signer to ServerConfig.AddHostKey.
    - The Signer passed to AddHostKey does not also implement AlgorithmSigner.
    - The Signer passed to AddHostKey does return a key of type “ssh-rsa” from its PublicKey method.

    Servers that only use Signer implementations provided by the ssh package are
    unaffected. This is CVE-2022-27191.

    Alla prossima,

    Filippo for the Go Security team

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 17, 2022

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe containerd wouldn't act as a "ssl server" though.

@thaJeztah
Copy link
Copy Markdown
Member Author

Yes, I don't expect it's affecting the code in this repository (vulnerability scanners may still flag the binary / repository because it has a dependency with a vulnerability though 😞); I had the commit message on my clipboard so went a quick round through some repositories 😂

@AkihiroSuda AkihiroSuda merged commit 46598b8 into containerd:main Mar 18, 2022
@thaJeztah thaJeztah deleted the bump_crypto branch March 18, 2022 06:32
@estesp estesp added the cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch label Aug 29, 2022
@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 29, 2022

Cherry picked to release/1.6 in #7340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants