Optimize loading performance for cri recover#6680
Conversation
|
Hi @linxiulei. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
cc: @Random-Liu |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Looks like the restart test doesn't like your changes to the reload/recover flow? |
|
Silly me. The errgroup is supposed to not be reused after Wait() |
This comment was marked as outdated.
This comment was marked as outdated.
|
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
rebase might fix the CI issue.
|
Build succeeded.
|
|
Build succeeded.
|
Parallelizing them decreases loading duration. Time to complete recover(): * Without competing IOs + without opt: 21s * Without competing IOs + with opt: 14s * Competing IOs + without opt: 3m44s * Competing IOs + with opt: 33s Signed-off-by: Eric Lin <[email protected]>
|
Build succeeded.
|
5 participants
This PR tries to decrease time duration to recover when cri service is restarted. Time needed for cri service to load db/sandboxes/containers/images is significantly high when under IO pressure.
Time to complete recover():
Test environment:
fio --filename=file --size=100MB --direct=1 --rw=randrw --bs=4k --ioengine=libaio --iodepth=256 --runtime=3600 --numjobs=4 --time_based --group_reporting --name=iops-test-job --eta-newline=1