[release/1.6] cherry-pick: Update TestNormalize to only test Windows#6673
Merged
kzys merged 1 commit intocontainerd:release/1.6from Mar 14, 2022
Merged
[release/1.6] cherry-pick: Update TestNormalize to only test Windows#6673kzys merged 1 commit intocontainerd:release/1.6from
kzys merged 1 commit intocontainerd:release/1.6from
Conversation
Member
Author
|
Cherry-pick of #6569 |
Member
|
maybe have to cherry pick #6666 first.. |
The output of platforms.DefaultSpec() and the normalized version of the default platform on 32- and 64-bit ARM are not comparable. This test was added to validate not losing Windows-specific information during normalize of the platform object, so for now we are moving this to be a Windows-only test until we resolve the right behavior on ARM. Signed-off-by: Phil Estes <[email protected]> (cherry picked from commit 807ded4)
fuweid
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of platforms.DefaultSpec() and the normalized version of the
default platform on 32- and 64-bit ARM are not comparable. This test
was added to validate not losing Windows-specific information during
normalize of the platform object, so for now we are moving this to be a
Windows-only test until we resolve the right behavior on ARM.
Signed-off-by: Phil Estes [email protected]
(cherry picked from commit 807ded4)
This should allow ARM64 testing to be successful on this release branch again.