Skip to content

Turn paths from cmdline into absolute paths#6672

Merged
kzys merged 1 commit intocontainerd:mainfrom
linxiulei:fix_rel
Apr 6, 2022
Merged

Turn paths from cmdline into absolute paths#6672
kzys merged 1 commit intocontainerd:mainfrom
linxiulei:fix_rel

Conversation

@linxiulei
Copy link
Copy Markdown
Contributor

@linxiulei linxiulei commented Mar 12, 2022

Snapshotter service returning relative paths confuses the client (i.e.
ctr).

Closes: #6671

Signed-off-by: Eric Lin [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 12, 2022

Hi @linxiulei. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 12, 2022

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 12, 2022

Build succeeded.

dmcgowan
dmcgowan reviewed Mar 15, 2022
View reviewed changes
Comment thread cmd/containerd/command/main.go Outdated
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2022

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 16, 2022

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 17, 2022

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 17, 2022

Build succeeded.

kzys
kzys reviewed Mar 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about handling them in the callee side? It is bit odd to see the caller (main.go) knows that these 2 parameters have to be absolute paths.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Mar 25, 2022

@kzys I think that the current related path will show unexpected error mentioned in #6671 .
This change can make debug easier 😂

fuweid
fuweid approved these changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@linxiulei
Turn paths from cmdline into absolute paths
44a8ac7 
Snapshotter service returning relative paths confuses the client (i.e.
ctr).

Closes: containerd#6671

Signed-off-by: Eric Lin <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 27, 2022

Build succeeded.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 6, 2022

ping @kzys

@kzys kzys merged commit 6fdaebd into containerd:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan left review comments

@kzys kzys kzys approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to create container when containerd uses relative directories

6 participants

@linxiulei @k8s-ci-robot @fuweid @kzys @dmcgowan @estesp