Skip to content

fix: ctr run --cni get failed#6670

Merged
crosbymichael merged 1 commit intocontainerd:mainfrom
CloudWikiFun:ctr_run_cni
Mar 16, 2022
Merged

fix: ctr run --cni get failed#6670
crosbymichael merged 1 commit intocontainerd:mainfrom
CloudWikiFun:ctr_run_cni

Conversation

@CloudWikiFun
Copy link
Copy Markdown
Contributor

@CloudWikiFun CloudWikiFun commented Mar 12, 2022

when user executes ctr run --cni to start a container,it will call cni plugin to create network .But when user kills it,the network won’t be removed. if we run a container with same namespace and name again will trigger a bug. we should remove the network when user kills task if it enables cni plugin.

Fix:#6604

Signed-off-by: SongJiang Han [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 12, 2022

Hi @snbc. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 12, 2022

Build succeeded.

@CloudWikiFun CloudWikiFun force-pushed the ctr_run_cni branch 4 times, most recently from f2f30c8 to 47d7c68 Compare March 12, 2022 13:57
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 12, 2022

Build succeeded.

@CloudWikiFun CloudWikiFun marked this pull request as ready for review March 12, 2022 14:32
crosbymichael
crosbymichael reviewed Mar 14, 2022
View reviewed changes
Comment thread cmd/ctr/commands/run/run_unix.go Outdated
@CloudWikiFun
fix: ctr run --cni get failed
2a0b2ee 
   when   user  executes ctr run --cni to start a container,it will call cni plugin to create network .But when user kills it,the network won’t be removed. if we run a container with same namespace and name again will trigger a bug. we should remove the network when user kills task if it enables cni plugin.

Fix:containerd#6604

Signed-off-by: SongJiang Han <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2022

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 15, 2022

Build succeeded.

estesp
estesp approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael crosbymichael merged commit de9344d into containerd:main Mar 16, 2022
@estesp estesp mentioned this pull request Oct 14, 2022
Closed
@Iceber Iceber mentioned this pull request Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crosbymichael crosbymichael crosbymichael approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CloudWikiFun @k8s-ci-robot @crosbymichael @estesp @dmcgowan