Skip to content

Fix link in getting-started.md#6663

Merged
kzys merged 1 commit intocontainerd:mainfrom
tnqn:fix-link
Mar 11, 2022
Merged

Fix link in getting-started.md#6663
kzys merged 1 commit intocontainerd:mainfrom
tnqn:fix-link

Conversation

@tnqn
Copy link
Copy Markdown
Contributor

@tnqn tnqn commented Mar 11, 2022

No description provided.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Mar 11, 2022

Hi @tnqn. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 11, 2022

Build succeeded.

Zyqsempai
Zyqsempai reviewed Mar 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnqn Please do sign your commit(git commit -s)

@tnqn
Copy link
Copy Markdown
Contributor Author

tnqn commented Mar 11, 2022

@tnqn Please do sign your commit(git commit -s)

@Zyqsempai done, thanks for reminding

estesp
estesp approved these changes Mar 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 11, 2022

Build succeeded.

kzys
kzys approved these changes Mar 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would go to github.com/docs but it won't. GitHub is smarter than I thought.

LGTM!

@kzys kzys merged commit 3cb4f5b into containerd:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tnqn @k8s-ci-robot @kzys @estesp @Zyqsempai