Hi @FabHof. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Build succeeded.

• containerd-build-arm64 : RETRY_LIMIT in 4m 07s (non-voting)
• containerd-test-arm64 : RETRY_LIMIT in 6m 38s (non-voting)
• containerd-integration-test-arm64 : RETRY_LIMIT in 24m 46s (non-voting)

The default string format of the UnexpectedStatusError holds less information than these formulated errors being replaced (status only, vs. status, host, and path currently) even though clearly the error struct has more data; don't know if anyone relies on the current response contents?

I'd like to avoid reducing information on the errors. It is useful for troubleshooting.

I would expect errors.As(err, myUnexpectedResponse) to work with every function that can have an unexpected http response. I really don't like relying on stings.

Maybe this improved default error string is better?

func (e ErrUnexpectedStatus) Error() string {
-	return fmt.Sprintf("unexpected status: %s", e.Status)
+	return fmt.Sprintf("unexpected status from %s request to %s: %s", e.RequestMethod, e.RequestURL, e.Status)
}

Build succeeded.

• containerd-build-arm64 : RETRY_LIMIT in 3m 47s (non-voting)
• containerd-test-arm64 : RETRY_LIMIT in 6m 03s (non-voting)
• containerd-integration-test-arm64 : RETRY_LIMIT in 24m 55s (non-voting)