Skip to content

cri: relax test for system without hugetlb#6596

Merged
crosbymichael merged 1 commit intocontainerd:mainfrom
zhsj:relax-hugetlb
Mar 1, 2022
Merged

cri: relax test for system without hugetlb#6596
crosbymichael merged 1 commit intocontainerd:mainfrom
zhsj:relax-hugetlb

Conversation

@zhsj
Copy link
Copy Markdown
Contributor

@zhsj zhsj commented Feb 27, 2022

These unit tests don't check hugetlb. However by setting
TolerateMissingHugetlbController to false, these tests can't
be run on system without hugetlb (e.g. Debian buildd).

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 27, 2022

Hi @zhsj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 27, 2022

Build succeeded.

@zhsj
cri: relax test for system without hugetlb
352a8f4 
These unit tests don't check hugetlb. However by setting
TolerateMissingHugetlbController to false, these tests can't
be run on system without hugetlb (e.g. Debian buildd).

Signed-off-by: Shengjing Zhu <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 27, 2022

Build succeeded.

estesp
estesp approved these changes Feb 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; seems reasonable. Even the default spec config in the CRI sets this to true by default.

kzys
kzys approved these changes Feb 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@crosbymichael crosbymichael merged commit f57d1cf into containerd:main Mar 1, 2022
@zhsj zhsj deleted the relax-hugetlb branch March 2, 2022 01:16
@zhsj zhsj mentioned this pull request Mar 3, 2022
Closed
@thaJeztah thaJeztah mentioned this pull request Mar 24, 2022
Merged
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@crosbymichael crosbymichael crosbymichael approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhsj @k8s-ci-robot @kzys @crosbymichael @estesp @thaJeztah @AkihiroSuda