Hi @zhsj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 10s (non-voting)
• containerd-test-arm64 : FAILURE in 6m 09s (non-voting)
• containerd-integration-test-arm64 : FAILURE in 25m 19s (non-voting)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 4m 27s (non-voting)
• containerd-test-arm64 : FAILURE in 5m 47s (non-voting)
• containerd-integration-test-arm64 : FAILURE in 25m 07s (non-voting)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 4m 55s (non-voting)
• containerd-test-arm64 : FAILURE in 5m 40s (non-voting)
• containerd-integration-test-arm64 : FAILURE in 25m 10s (non-voting)

BTW, should we enable cgroupsv2 integration test in CI?

We have cgroups v2 testing happening in 2 places, both by running a nested VM running Fedora 35:

1. the unit tests in the containerd/cgroups project run in a VM with v2 enabled
2. here in the main containerd project, the 2 jobs starting with "CI / CGroupsV2 - ..." in the name run the tests with v2 enabled (via Fedora 35 in a VM).

Build succeeded.

• containerd-build-arm64 : SUCCESS in 4m 24s (non-voting)
• containerd-test-arm64 : FAILURE in 5m 37s (non-voting)
• containerd-integration-test-arm64 : FAILURE in 26m 27s (non-voting)

here in the main containerd project, the 2 jobs starting with "CI / CGroupsV2 - ..." in the name run the tests with v2 enabled (via Fedora 35 in a VM).

Yes, but only integration test(code in integration/client) has been run. CRI integration is not.

/ok-to-test

here in the main containerd project, the 2 jobs starting with "CI / CGroupsV2 - ..." in the name run the tests with v2 enabled (via Fedora 35 in a VM).

Yes, but only integration test(code in integration/client) has been run. CRI integration is not.

two cri integration buckets are available 1) kubernetes-sigs/cri-tools .. critest and 2) containerd/script/test/cri-integration.sh

Don't think we've tried containerd/script integration yet with v2 enabled in fedora..

Also not sure how much of CGroupsV2 is being tested right now in the k8s prow driven node e2e bucket. They've had some features enable now so I would expect some buckets to be there.

Don't think we've tried containerd/script integration yet.

https://github.com/containerd/containerd/blob/main/.github/workflows/ci.yml#L397 Only on ubuntu-18.04.

I'm not sure it should be added to vagrant based cgroupsv2 CI. It may become more flaky...

Don't think we've tried containerd/script integration yet.

https://github.com/containerd/containerd/blob/main/.github/workflows/ci.yml#L397 Only on ubuntu-18.04.

I'm not sure it should be added to vagrant based cgroupsv2 CI. It may become more flaky...

nod it wasn't written to run in a vagrant vm.. vague memory of some restart tests that would/may require a different design..