Skip to content

Fix build with gccgo#6579

Merged
mxpv merged 1 commit intocontainerd:mainfrom
zhsj:fix-gccgo
Feb 22, 2022
Merged

Fix build with gccgo#6579
mxpv merged 1 commit intocontainerd:mainfrom
zhsj:fix-gccgo

Conversation

@zhsj
Copy link
Copy Markdown
Contributor

@zhsj zhsj commented Feb 21, 2022

gccgo changes the mangling scheme
golang/gofrontend@b483d0e

The change is available in gcc-11, which is the least version that
implements go1.16.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @zhsj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gccgo changes the mangling scheme
golang/gofrontend@b483d0e

The change is available in gcc-11, which is the least version that
implements go1.16.

Signed-off-by: Shengjing Zhu <[email protected]>
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 21, 2022

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit e1026f5 into containerd:main Feb 22, 2022
@zhsj zhsj deleted the fix-gccgo branch February 22, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants