Use containerd/protobuild instead of stevvooe/protobuild#6578
Merged
estesp merged 1 commit intocontainerd:mainfrom Mar 1, 2022
Merged
Use containerd/protobuild instead of stevvooe/protobuild#6578estesp merged 1 commit intocontainerd:mainfrom
estesp merged 1 commit intocontainerd:mainfrom
Conversation
kzys
commented
Feb 21, 2022
|
|
||
| # install `protobuild` and other commands | ||
| go install github.com/stevvooe/protobuild@v0.1.0 | ||
| go install github.com/containerd/protobuild@7e5ee24bc1f70e9e289fef15e2631eb3491320bf |
Member
Author
There was a problem hiding this comment.
While protobuild wouldn't need any more changes for this migration, personally I'd like to cut a version once we finish #6564.
kzys
force-pushed
the
upgrade-protobuild
branch
from
2979608 to
9ee83b1
Compare
|
Build succeeded.
|
The new version still supports gogo/protobuf, but can be used with newer protobuf packages if version = 2. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
upgrade-protobuild
branch
from
9ee83b1 to
77c0539
Compare
|
Build succeeded.
|
mxpv
approved these changes
Feb 22, 2022
Member
Author
|
@estesp Can you take a look? This is a low-risk change I believe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version still supports gogo/protobuf, but can be used with newer
protobuf packages if version = 2.
Signed-off-by: Kazuyoshi Kato [email protected]