Skip to content

Update TestContainerSymlinkVolumes to use windows path#6568

Merged
estesp merged 1 commit intocontainerd:mainfrom
katiewasnothere:cri_integration_tests_windows
Mar 3, 2022
Merged

Update TestContainerSymlinkVolumes to use windows path#6568
estesp merged 1 commit intocontainerd:mainfrom
katiewasnothere:cri_integration_tests_windows

Conversation

@katiewasnothere
Copy link
Copy Markdown

@katiewasnothere katiewasnothere commented Feb 18, 2022

When mounting a file from the host into a container on windows, the container mount path must resolve to the form "C:/path" or starting the container will fail. If these tests are run from a drive other than the C:/ drive on the host, the path will not be resolved in the expected form, causing failures. This PR updates TestContainerSymlinkVolumes to explicitly mount the expected file on the C drive of the container when running on windows.

Signed-off-by: Kathryn Baldauf [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 18, 2022

Hi @katiewasnothere. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 18, 2022

Build succeeded.

kzys
kzys reviewed Feb 18, 2022
View reviewed changes
Comment thread integration/container_volume_test.go Outdated
@katiewasnothere katiewasnothere force-pushed the cri_integration_tests_windows branch from 5c36798 to a3303e7 Compare February 19, 2022 02:15
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 19, 2022

Build succeeded.

kzys
kzys reviewed Feb 22, 2022
View reviewed changes
Comment thread integration/container_volume_test.go
estesp
estesp approved these changes Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit ab2f7dc into containerd:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@katiewasnothere @k8s-ci-robot @kzys @estesp