Do not use weak import#6558
Merged
crosbymichael merged 1 commit intocontainerd:mainfrom Mar 1, 2022
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
According to protocolbuffers/protobuf#9184 > Weak fields are an old and deprecated internal-only feature that we never > open sourced. This blocks us to upgrade protoc. Fixes containerd#6232. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
crosbymichael
approved these changes
Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to protocolbuffers/protobuf#9184
This blocks us to upgrade protoc.
Fixes #6232.
Signed-off-by: Kazuyoshi Kato [email protected]